Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update allowSharingAppStoreAccount deprecation message #4272

Merged

Conversation

fire-at-will
Copy link
Contributor

Description

Updates the deprecation message of allowSharingAppStoreAccount to tell people who are already using the field to continue using it and not remove it.

@fire-at-will fire-at-will requested a review from a team September 12, 2024 21:11
@aboedo aboedo added the pr:docs label Sep 12, 2024
Copy link
Member

@aboedo aboedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking care of this so fast!

Sources/Purchasing/Purchases/Purchases.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@jamesrb1 jamesrb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an odd caveat, and worthy of more explanation somewhere? And customers will have to live with the warning message.

Approving so you are not blocked.

@aboedo
Copy link
Member

aboedo commented Sep 13, 2024

@jamesrb1 this was already true before this PR, it's actually been this way for > 4 years.

So this PR is more surfacing a caveat that has implicitly been there for 4 years and making it explicit, rather than changing anything with regards to how things behave.

It actually came up yesterday when a customer ran into this, so we figured that we should at least improve the error message and related docs. It's very uncommon for it to come up, since the related feature has been deprecated for a very long time, but it's not impossible, so this is meant as a small improvement over the current status

@fire-at-will fire-at-will merged commit 38688f7 into main Sep 13, 2024
5 checks passed
@fire-at-will fire-at-will deleted the update-allowSharingAppStoreAccount-deprecation-message branch September 13, 2024 15:02
@vegaro vegaro added pr:other and removed pr:docs labels Sep 17, 2024
This was referenced Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants