-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update allowSharingAppStoreAccount deprecation message #4272
Update allowSharingAppStoreAccount deprecation message #4272
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for taking care of this so fast!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an odd caveat, and worthy of more explanation somewhere? And customers will have to live with the warning message.
Approving so you are not blocked.
@jamesrb1 this was already true before this PR, it's actually been this way for > 4 years. So this PR is more surfacing a caveat that has implicitly been there for 4 years and making it explicit, rather than changing anything with regards to how things behave. It actually came up yesterday when a customer ran into this, so we figured that we should at least improve the error message and related docs. It's very uncommon for it to come up, since the related feature has been deprecated for a very long time, but it's not impossible, so this is meant as a small improvement over the current status |
Description
Updates the deprecation message of
allowSharingAppStoreAccount
to tell people who are already using the field to continue using it and not remove it.